Skip to content

[backport core/1.34] Move cancel button into actionbar (#7297)#7298

Merged
christian-byrne merged 1 commit intocore/1.34from
backport/2903560-core-1.34
Dec 10, 2025
Merged

[backport core/1.34] Move cancel button into actionbar (#7297)#7298
christian-byrne merged 1 commit intocore/1.34from
backport/2903560-core-1.34

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Dec 9, 2025 •
edited by sync-by-unito bot
Loading

Summary

Backport of 2903560 to core/1.34 to place the cancel control alongside the run controls.

Changes

  • What: Move the interrupt button into the actionbar and remove the duplicate from the top menu.
  • Breaking: none
  • Dependencies: none

Review Focus

Check spacing/hover states of the new cancel control in docked vs floating layouts.

Screenshots (if applicable)

  • n/a

┆Issue is synchronized with this Notion page by Unito

@benceruleanlu
Move cancel button into actionbar (#7297)
e9734b9 
## Summary
Move the interrupt control into the actionbar so cancellation sits with
the run controls.

## Changes
- add a cancel button to the actionbar with the existing interrupt
tooltip and disabled state
- remove the cancel button and related execution wiring from the top
menu section to avoid duplication

## Review Focus
- spacing/hover states of the new cancel control in both docked and
floating modes

## Screenshots (if applicable)
- n/a

Tests: pnpm typecheck; pnpm lint:fix

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7297-Move-cancel-button-into-actionbar-2c46d73d36508198b00cf011390289f6)
by [Unito](https://www.unito.io)
Copilot AI review requested due to automatic review settings December 9, 2025 23:33
@benceruleanlu benceruleanlu requested a review from a team as a code owner December 9, 2025 23:33
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 9, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backport/2903560-core-1.34

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 9, 2025
@github-actions
Copy link

github-actions bot commented Dec 9, 2025 •
edited
Loading

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 12/09/2025, 11:35:17 PM UTC

🔗 Links

🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Dec 9, 2025 •
edited
Loading

🎭 Playwright Test Results

❌ Some tests failed

⏰ Completed at: 12/10/2025, 12:26:38 AM UTC

📈 Summary

  • Total Tests: 489
  • Passed: 469 ✅
  • Failed: 1 ❌
  • Flaky: 9 ⚠️
  • Skipped: 10 ⏭️

📊 Test Reports by Browser

  • ✅ chromium: View Report • ✅ 460 / ❌ 1 / ⚠️ 9 / ⏭️ 10
  • ✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

Copilot AI reviewed Dec 9, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is a backport from core/1.34 that relocates the interrupt/cancel button from the top menu section into the actionbar alongside the run controls for better UI organization.

  • Moves the cancel button from TopMenuSection.vue to ComfyActionbar.vue
  • Removes duplicate code and unused imports from TopMenuSection.vue
  • Adjusts spacing (margin-right to margin-left) to fit the new layout context

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/components/actionbar/ComfyActionbar.vue Adds the cancel button with associated logic, imports, and styling to the actionbar
src/components/TopMenuSection.vue Removes the cancel button and cleans up unused imports and functions

@benceruleanlu benceruleanlu added the New Browser Test Expectations New browser test screenshot should be set by github action label Dec 9, 2025
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Updating Playwright Expectations

@github-actions github-actions bot removed the New Browser Test Expectations New browser test screenshot should be set by github action label Dec 9, 2025
@christian-byrne christian-byrne merged commit bcd2050 into core/1.34 Dec 10, 2025
40 of 42 checks passed
@christian-byrne christian-byrne deleted the backport/2903560-core-1.34 branch December 10, 2025 03:16
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@christian-byrne christian-byrne christian-byrne approved these changes

Assignees

No one assigned

Labels

backport Backporting a PR onto a release candidate size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benceruleanlu @christian-byrne